lkml.org 
[lkml]   [2022]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/2] iio: adc: ti-adc128s052: Use get_unaligned_beXX()
On Fri, Dec 23, 2022 at 03:17:50PM +0000, Jonathan Cameron wrote:
> On Wed, 14 Dec 2022 14:02:01 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > This makes the driver code slightly easier to read.
> > While at it, use GENMASK() as well.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Hi Andy,
>
> Patch looks good, but it got me thinking. Why not just flip this driver
> over to using spi_write_then_read(). Would let us drop the DMA safety
> protections and simplify the code + use a __be16 as the read buffer
> and this would then be the slightly nicer aligned form.
>
> Worth doing whilst you are here?

OK, I will consider when I have time for this.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-03-26 23:22    [W:0.088 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site