| From | Geert Uytterhoeven <> | Date | Tue, 8 Nov 2022 09:39:53 +0100 | Subject | Re: [PATCH printk v3 24/40] tty: nfcon: use console_is_registered() |
| |
Hi John,
On Mon, Nov 7, 2022 at 3:16 PM John Ogness <john.ogness@linutronix.de> wrote: > Currently CON_ENABLED is being (mis)used to identify if the console > has been registered. This is not reliable because it can be set even > though registration failed or it can be unset, even though the console > is registered. > > Instead, use console_is_registered(). > > Signed-off-by: John Ogness <john.ogness@linutronix.de>
Thanks for your patch!
LGTM, so Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|