lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH printk v3 26/40] tty: hvc: use console_is_registered()
    Date
    It is not reliable to check for CON_ENABLED in order to identify if a
    console is registered. Use console_is_registered() instead.

    Signed-off-by: John Ogness <john.ogness@linutronix.de>
    ---
    drivers/tty/hvc/hvc_console.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
    index 4802cfaa107f..a683e21df19c 100644
    --- a/drivers/tty/hvc/hvc_console.c
    +++ b/drivers/tty/hvc/hvc_console.c
    @@ -264,8 +264,8 @@ static void hvc_port_destruct(struct tty_port *port)

    static void hvc_check_console(int index)
    {
    - /* Already enabled, bail out */
    - if (hvc_console.flags & CON_ENABLED)
    + /* Already registered, bail out */
    + if (console_is_registered(&hvc_console))
    return;

    /* If this index is what the user requested, then register
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-11-07 15:18    [W:2.328 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site