lkml.org 
[lkml]   [2022]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH printk v3 27/40] tty: serial: earlycon: use console_is_registered()
    Date
    It is not reliable to check for CON_ENABLED in order to identify if a
    console is registered. Use console_is_registered() instead.

    Signed-off-by: John Ogness <john.ogness@linutronix.de>
    ---
    drivers/tty/serial/earlycon.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
    index a5f380584cda..4f6e9bf57169 100644
    --- a/drivers/tty/serial/earlycon.c
    +++ b/drivers/tty/serial/earlycon.c
    @@ -181,7 +181,7 @@ int __init setup_earlycon(char *buf)
    if (!buf || !buf[0])
    return -EINVAL;

    - if (early_con.flags & CON_ENABLED)
    + if (console_is_registered(&early_con))
    return -EALREADY;

    again:
    @@ -253,7 +253,7 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
    bool big_endian;
    u64 addr;

    - if (early_con.flags & CON_ENABLED)
    + if (console_is_registered(&early_con))
    return -EALREADY;

    spin_lock_init(&port->lock);
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-11-07 15:19    [W:3.240 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site