Messages in this thread | | | From | Masahiro Yamada <> | Date | Wed, 23 Nov 2022 22:03:09 +0900 | Subject | Re: [PATCH 08/18] net: enetc: fix mixed module-builtin object |
| |
On Sun, Nov 20, 2022 at 8:07 AM Alexander Lobakin <alobakin@pm.me> wrote: > > From: Masahiro Yamada <masahiroy@kernel.org> > > With CONFIG_FSL_ENETC=m and CONFIG_FSL_ENETC_VF=y (or vice versa), > $(common-objs) are linked to a module and also to vmlinux even though > the expected CFLAGS are different between builtins and modules. > > This is the same situation as fixed by commit 637a642f5ca5 ("zstd: > Fixing mixed module-builtin objects"). > > Introduce the new module, fsl-enetc-core, to provide the common > functions to fsl-enetc and fsl-enetc-vf. > > [ alobakin: add exports to common functions ] > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > Reviewed-by: Alexander Lobakin <alobakin@pm.me> > Signed-off-by: Alexander Lobakin <alobakin@pm.me> > --- > drivers/net/ethernet/freescale/enetc/Kconfig | 5 +++++ > drivers/net/ethernet/freescale/enetc/Makefile | 7 ++++--- > drivers/net/ethernet/freescale/enetc/enetc.c | 21 +++++++++++++++++++ > .../net/ethernet/freescale/enetc/enetc_cbdr.c | 7 +++++++ > .../ethernet/freescale/enetc/enetc_ethtool.c | 2 ++ > .../net/ethernet/freescale/enetc/enetc_pf.c | 2 ++ > .../net/ethernet/freescale/enetc/enetc_vf.c | 2 ++ > 7 files changed, 43 insertions(+), 3 deletions(-)
I think you can grab Author since I did not finish this patch. (and of course, I did not test it at all)
You can remove a blank line after MODULE_IMPORT_NS()
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
-- Best Regards Masahiro Yamada
| |