| From | Masahiro Yamada <> | Date | Thu, 24 Nov 2022 01:12:34 +0900 | Subject | Re: [PATCH 10/18] EDAC: i10nm, skx: fix mixed module-builtin object |
| |
On Sun, Nov 20, 2022 at 8:08 AM Alexander Lobakin <alobakin@pm.me> wrote: > > With CONFIG_EDAC_SKX=m and CONFIG_EDAC_I10NM=y (or vice versa), > skx_common.o are linked to a module and also to vmlinux even though > the expected CFLAGS are different between builtins and modules: > > > scripts/Makefile.build:252: ./drivers/edac/Makefile: skx_common.o > > is added to multiple modules: i10nm_edac skx_edac > > This is the same situation as fixed by commit 637a642f5ca5 ("zstd: > Fixing mixed module-builtin objects"). > > Introduce the new module, skx_edac_common, to provide the common > functions to skx_edac and i10nm_edac. skx_adxl_{get,put}() loose > their __init/__exit annotations in order to become exportable. > > Fixes: d4dc89d069aa ("EDAC, i10nm: Add a driver for Intel 10nm server processors") > Suggested-by: Masahiro Yamada <masahiroy@kernel.org> > Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
-- Best Regards Masahiro Yamada
|