| From | Masahiro Yamada <> | Date | Thu, 24 Nov 2022 06:02:50 +0900 | Subject | Re: [PATCH 15/18] net: dpaa2: fix mixed module-builtin object |
| |
On Sun, Nov 20, 2022 at 8:09 AM Alexander Lobakin <alobakin@pm.me> wrote: > > With CONFIG_FSL_DPAA2_ETH=m and CONFIG_FSL_DPAA2_SWITCH=y (or vice > versa), dpaa2-mac.o and dpmac.o are linked to a module and also to > vmlinux even though the expected CFLAGS are different between > builtins and modules. > This is the same situation as fixed by > commit 637a642f5ca5 ("zstd: Fixing mixed module-builtin objects"). > There's also no need to duplicate relatively big piece of object > code into two modules. > > Introduce the new module, fsl-dpaa2-mac, to provide the common > functions to both fsl-dpaa2-eth and fsl-dpaa2-switch. > > Misc: constify and shrink @dpaa2_mac_ethtool_stats while at it. > > Fixes: 84cba72956fd ("dpaa2-switch: integrate the MAC endpoint support") > Suggested-by: Masahiro Yamada <masahiroy@kernel.org> > Signed-off-by: Alexander Lobakin <alobakin@pm.me> > ---
Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
-- Best Regards Masahiro Yamada
|