lkml.org 
[lkml]   [2022]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi
On 17/11/2022 13:51, Krzysztof Kozlowski wrote:
> On 16/11/2022 11:31, Abel Vesa wrote:
>> From: Neil Armstrong <neil.armstrong@linaro.org>
>>
>> Add nodes for pm8010 in separate dtsi file.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++
>> 1 file changed, 84 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>> new file mode 100644
>> index 000000000000..0ea641e12209
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi
>> @@ -0,0 +1,84 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>
> Any reason why this is licensed BSD-3 clause? It's not a recommended
> license (2 clause is). Same for other patches.

Probably a bad copy-paste from other existing files.

While checking, the majority of arch/arm64/boot/dts/qcom/pm*.dtsi uses BSD-3-Clause
so it seems this was done for quite a while now.

>
>> +/*
>> + * Copyright (c) 2022, Linaro Limited
>> + */
>> +
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/spmi/spmi.h>
>> +
>> +/ {
>> + thermal-zones {
>> + pm8010-m-thermal {
>> + polling-delay-passive = <100>;
>> + polling-delay = <0>;
>> +
>> + thermal-sensors = <&pm8010_m_temp_alarm>;
>> +
>> + trips {
>> + trip0 {
>> + temperature = <95000>;
>> + hysteresis = <0>;
>> + type = "passive";
>> + };
>> +
>> + trip1 {
>> + temperature = <115000>;
>> + hysteresis = <0>;
>> + type = "hot";
>> + };
>> + };
>> + };
>> +
>> + pm8010-n-thermal {
>> + polling-delay-passive = <100>;
>> + polling-delay = <0>;
>> +
>> + thermal-sensors = <&pm8010_n_temp_alarm>;
>> +
>> + trips {
>> + trip0 {
>> + temperature = <95000>;
>> + hysteresis = <0>;
>> + type = "passive";
>> + };
>> +
>> + trip1 {
>> + temperature = <115000>;
>> + hysteresis = <0>;
>> + type = "hot";
>> + };
>> + };
>> + };
>> + };
>> +};
>> +
>> +
>
> Just one blank line.
>
>
> Best regards,
> Krzysztof
>

\
 
 \ /
  Last update: 2022-11-18 16:03    [W:0.092 / U:2.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site