Messages in this thread | | | Date | Fri, 28 Oct 2022 17:57:01 -0400 | Subject | Re: [PATCH v4 10/16] dt-bindings: phy: qcom,qmp-pcie: rename current bindings | From | Krzysztof Kozlowski <> |
| |
On 28/10/2022 09:35, Johan Hovold wrote: > The current QMP PCIe PHY bindings are based on the original MSM8996 > binding which provided multiple PHYs per IP block and these in turn were > described by child nodes. > > Later QMP PCIe PHY blocks only provide a single PHY and the remnant > child node does not really reflect the hardware. > > The original MSM8996 binding also ended up describing the individual > register blocks as belonging to either the wrapper node or the PHY child > nodes. > > This is an unnecessary level of detail which has lead to problems when > later IP blocks using different register layouts have been forced to fit > the original mould rather than updating the binding. The bindings are > arguable also incomplete as they only the describe register blocks used > by the current Linux drivers (e.g. does not include the per lane PCS > registers). > > In preparation for adding new bindings for SC8280XP which further > bindings can be based on, rename the current schema file after IPQ8074, > which was the first SoC added to the bindings after MSM8996 (which has > already been split out), and add a reference to the SC8280XP bindings. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > ---
Also missing cc devicetree list.
Best regards, Krzysztof
| |