lkml.org 
[lkml]   [2022]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 07/16] phy: qcom-qmp-pcie: clean up PHY lane init
    Date
    Clean up the PHY lane initialisation somewhat by adding further
    temporary variables and programming both tx and rx for the second lane
    after the first lane.

    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    ---
    drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 13 +++++++------
    1 file changed, 7 insertions(+), 6 deletions(-)

    diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
    index bd946438e3c3..dd7e72424fc0 100644
    --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
    +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
    @@ -1835,18 +1835,19 @@ static void qmp_pcie_lanes_init(struct qmp_pcie *qmp, const struct qmp_phy_cfg_t
    const struct qmp_phy_cfg *cfg = qmp->cfg;
    void __iomem *tx = qmp->tx;
    void __iomem *rx = qmp->rx;
    + void __iomem *tx2 = qmp->tx2;
    + void __iomem *rx2 = qmp->rx2;

    if (!tables)
    return;

    qmp_pcie_configure_lane(tx, tables->tx, tables->tx_num, 1);
    -
    - if (cfg->lanes >= 2)
    - qmp_pcie_configure_lane(qmp->tx2, tables->tx, tables->tx_num, 2);
    -
    qmp_pcie_configure_lane(rx, tables->rx, tables->rx_num, 1);
    - if (cfg->lanes >= 2)
    - qmp_pcie_configure_lane(qmp->rx2, tables->rx, tables->rx_num, 2);
    +
    + if (cfg->lanes >= 2) {
    + qmp_pcie_configure_lane(tx2, tables->tx, tables->tx_num, 2);
    + qmp_pcie_configure_lane(rx2, tables->rx, tables->rx_num, 2);
    + }
    }

    static void qmp_pcie_pcs_init(struct qmp_pcie *qmp, const struct qmp_phy_cfg_tables *tables)
    --
    2.37.3
    \
     
     \ /
      Last update: 2022-10-28 15:39    [W:5.097 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site