Messages in this thread Patch in this message | | | From | Ashok Raj <> | Subject | [PATCH 07/13] x86/microcode: Move late-load warning to earlier where kernel taint happens | Date | Fri, 14 Oct 2022 13:09:07 -0700 |
| |
Move where the late loading warning is being issued to earlier in the call. This would put the warn and taint in the same function.
Just a tidy thing, no functional changes.
Signed-off-by: Ashok Raj <ashok.raj@intel.com> --- arch/x86/kernel/cpu/microcode/core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c index 50652b019233..7a8fcb914b6a 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -571,9 +571,6 @@ static int microcode_reload_late(void) { int old = boot_cpu_data.microcode, ret; - pr_err("Attempting late microcode loading - it is dangerous and taints the kernel.\n"); - pr_err("You should switch to early loading, if possible.\n"); - /* * Used for late_load entry and exit rendezvous */ @@ -624,6 +621,8 @@ static ssize_t reload_store(struct device *dev, if (ret) goto put; + pr_err("Attempting late microcode loading - it is dangerous and taints the kernel.\n"); + pr_err("You should switch to early loading, if possible.\n"); tmp_ret = microcode_ops->request_microcode_fw(bsp, µcode_pdev->dev, true); if (tmp_ret != UCODE_NEW) goto put; -- 2.34.1
| |