Messages in this thread | | | Date | Wed, 19 Oct 2022 12:12:00 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 01/13] x86/microcode/intel: Print old and new rev after early microcode update |
| |
On Fri, Oct 14, 2022 at 01:09:01PM -0700, Ashok Raj wrote: > @@ -435,10 +435,10 @@ static bool load_builtin_intel_microcode(struct cpio_data *cp) > * Print ucode update info. > */ > static void > -print_ucode_info(struct ucode_cpu_info *uci, unsigned int date) > +print_ucode_info(u32 old_rev, struct ucode_cpu_info *uci, unsigned int date) > { > - pr_info_once("microcode updated early to revision 0x%x, date = %04x-%02x-%02x\n", > - uci->cpu_sig.rev, > + pr_info_once("microcode updated early from 0x%x to revision 0x%x, date = %04x-%02x-%02x\n",
That already has the "microcode: " prefix from pr_fmt so make that
"early update: 0x%x -> 0x%x, date = %04x-%02x-%02x\n"
and fix the late update message too, pls, to look the same without the "early" in there.
> @@ -479,13 +481,15 @@ static void print_ucode(struct ucode_cpu_info *uci) > > delay_ucode_info_p = (int *)__pa_nodebug(&delay_ucode_info); > current_mc_date_p = (int *)__pa_nodebug(¤t_mc_date); > + old_rev_p = (u32 *)__pa_nodebug(&early_old_rev);
No, you should add a
u32 prev_rev;
to struct ucode_cpu_info, save it there and access it where needed.
Then I can do the same prev -> next revision dumping on the AMD side.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |