Messages in this thread | | | Date | Mon, 31 Jan 2022 23:33:49 +0100 | From | Piotr Masłowski <> | Subject | Re: [PATCH v4 7/9] brcmfmac: of: Use devm kstrdup for board type & check for errors |
| |
On Mon, Jan 31, 2022 at 5:07 PM Hector Martin <marcan@marcan.st> wrote: > >This was missing a NULL check, and we can collapse the strlen/alloc/copy >into a devm_kstrdup().
...
> /* get rid of '/' in the compatible string to be able to find the FW */ > len = strlen(tmp) + 1; >- board_type = devm_kzalloc(dev, len, >GFP_KERNEL); >- strscpy(board_type, tmp, len); >+ board_type = devm_kstrdup(dev, tmp, GFP_KERNEL);
Also `len` can be dropped, since it is now unused.
-- Best regards, Piotr Masłowski
| |