Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 31 Jan 2022 18:26:56 +0200 | Subject | Re: [PATCH v4 1/9] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path |
| |
On Mon, Jan 31, 2022 at 6:07 PM Hector Martin <marcan@marcan.st> wrote: > > This avoids leaking memory if brcmf_chip_get_raminfo fails. Note that > the CLM blob is released in the device remove path.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Fixes: 82f93cf46d60 ("brcmfmac: get chip's default RAM info during PCIe setup") > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Cc: stable@vger.kernel.org > Signed-off-by: Hector Martin <marcan@marcan.st> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > index 8b149996fc00..f876b1d8d00d 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > @@ -1777,6 +1777,8 @@ static void brcmf_pcie_setup(struct device *dev, int ret, > ret = brcmf_chip_get_raminfo(devinfo->ci); > if (ret) { > brcmf_err(bus, "Failed to get RAM info\n"); > + release_firmware(fw); > + brcmf_fw_nvram_free(nvram); > goto fail; > } > > -- > 2.33.0 >
-- With Best Regards, Andy Shevchenko
| |