Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 31 Jan 2022 19:49:00 +0200 | Subject | Re: [PATCH v4 3/9] brcmfmac: firmware: Do not crash on a NULL board_type |
| |
On Mon, Jan 31, 2022 at 6:49 PM Kalle Valo <kvalo@kernel.org> wrote: > Andy Shevchenko <andy.shevchenko@gmail.com> writes: > > On Mon, Jan 31, 2022 at 6:07 PM Hector Martin <marcan@marcan.st> wrote:
...
> >> + if (!board_type) > >> + return NULL; > > > > I still think it's better to have both callers do the same thing. > > > > Now it will be the double check in one case, > > I already applied a similar patch: > > https://git.kernel.org/wireless/wireless/c/665408f4c3a5
"Similar" means that it took into account the concern I expressed here :-) I would have done slightly differently, but the main idea is the same. Thank you!
-- With Best Regards, Andy Shevchenko
| |