lkml.org 
[lkml]   [2022]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/16] scsi: libsas: Add sas_execute_ssp_tmf()
On Tue, Jan 25, 2022 at 07:32:44PM +0800, John Garry wrote:
> Add a function to issue an SSP TMF.
>
> Add a temp prototype to keep make W=1 happy.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/libsas/sas_scsi_host.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index 93ca6da63104..cfdf4a031be0 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -938,6 +938,11 @@ int sas_execute_tmf(struct domain_device *device, void *parameter,
> task->dev = device;
> task->task_proto = device->tproto;
>
> + if (dev_is_sata(device)) {
> + } else {
> + memcpy(&task->ssp_task, parameter, para_len);
> + }

This looks strange, why not:

if (!dev_is_sata(device))
memcpy(&task->ssp_task, parameter, para_len);

\
 
 \ /
  Last update: 2022-01-27 11:25    [W:0.280 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site