lkml.org 
[lkml]   [2022]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 01/16] scsi: libsas: Use enum for response frame DATAPRES field
Date
As defined in table 126 of the SAS spec 1.1, use an enum for the DATAPRES
field, which makes reading the code easier.

Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/scsi/libsas/sas_task.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/libsas/sas_task.c b/drivers/scsi/libsas/sas_task.c
index 2966ead1d421..7240fd22b154 100644
--- a/drivers/scsi/libsas/sas_task.c
+++ b/drivers/scsi/libsas/sas_task.c
@@ -7,6 +7,12 @@
#include <scsi/sas.h>
#include <scsi/libsas.h>

+enum {
+ NO_DATA = 0,
+ RESPONSE_DATA = 1,
+ SENSE_DATA = 2,
+};
+
/* fill task_status_struct based on SSP response frame */
void sas_ssp_task_response(struct device *dev, struct sas_task *task,
struct ssp_response_iu *iu)
@@ -15,11 +21,11 @@ void sas_ssp_task_response(struct device *dev, struct sas_task *task,

tstat->resp = SAS_TASK_COMPLETE;

- if (iu->datapres == 0)
+ if (iu->datapres == NO_DATA)
tstat->stat = iu->status;
- else if (iu->datapres == 1)
+ else if (iu->datapres == RESPONSE_DATA)
tstat->stat = iu->resp_data[3];
- else if (iu->datapres == 2) {
+ else if (iu->datapres == SENSE_DATA) {
tstat->stat = SAS_SAM_STAT_CHECK_CONDITION;
tstat->buf_valid_size =
min_t(int, SAS_STATUS_BUF_SIZE,
--
2.26.2
\
 
 \ /
  Last update: 2022-01-25 12:42    [W:2.191 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site