Messages in this thread | | | Subject | Re: [PATCH 01/16] scsi: libsas: Use enum for response frame DATAPRES field | From | John Garry <> | Date | Thu, 27 Jan 2022 10:42:38 +0000 |
| |
On 27/01/2022 10:19, Christoph Hellwig wrote: > On Tue, Jan 25, 2022 at 07:32:37PM +0800, John Garry wrote: >> - if (iu->datapres == 0) >> + if (iu->datapres == NO_DATA) >> tstat->stat = iu->status; >> - else if (iu->datapres == 1) >> + else if (iu->datapres == RESPONSE_DATA) >> tstat->stat = iu->resp_data[3]; >> - else if (iu->datapres == 2) { >> + else if (iu->datapres == SENSE_DATA) { > Maybe use a switch here to make it more obvious? > .
ok, I can include that suggestion.
Thanks, John
| |