Messages in this thread | | | Subject | Re: [PATCH v4 8/8] nvme-rdma: Unfreeze queues on reconnect | From | Hannes Reinecke <> | Date | Wed, 4 Aug 2021 09:25:08 +0200 |
| |
On 8/2/21 1:26 PM, Daniel Wagner wrote: > During the queue teardown in nvme_rdma_teardown_io_queues() freeze is > called unconditionally. When we reconnect we need to pair the freeze > with an unfreeze to avoid hanging I/Os. For newly created connection > this is not needed. > > Fixes: 9f98772ba307 ("nvme-rdma: fix controller reset hang during traffic") > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/nvme/host/rdma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c > index de2a8950d282..21a8a5353af0 100644 > --- a/drivers/nvme/host/rdma.c > +++ b/drivers/nvme/host/rdma.c > @@ -901,6 +901,8 @@ static int nvme_rdma_configure_admin_queue(struct nvme_rdma_ctrl *ctrl, > error = PTR_ERR(ctrl->ctrl.admin_q); > goto out_cleanup_fabrics_q; > } > + } else { > + nvme_unfreeze(&ctrl->ctrl); > } > > error = nvme_rdma_start_queue(ctrl, 0); > Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
| |