Messages in this thread | | | Date | Wed, 4 Aug 2021 10:08:47 +0200 | From | Daniel Wagner <> | Subject | Re: [PATCH v4 6/8] nvme-fc: fix controller reset hang during traffic |
| |
On Wed, Aug 04, 2021 at 09:23:49AM +0200, Hannes Reinecke wrote: > There still is now an imbalance, as we're always calling > 'nvme_unfreeze()' (irrespective on the number of queues), but will only > call 'nvme_start_freeze()' if we have more than one queue. > > This might lead to an imbalance on the mq_freeze_depth counter. > Wouldn't it be better to move the call to 'nvme_start_freeze()' out of > the if() condition to avoid the imbalance?
What about something like nmve_is_frozen() which would avoid the tracking of the queue state open coded as it is right?
| |