lkml.org 
[lkml]   [2021]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 6/8] nvme-fc: fix controller reset hang during traffic
    On Wed, Aug 04, 2021 at 09:23:49AM +0200, Hannes Reinecke wrote:
    > There still is now an imbalance, as we're always calling
    > 'nvme_unfreeze()' (irrespective on the number of queues), but will only
    > call 'nvme_start_freeze()' if we have more than one queue.
    >
    > This might lead to an imbalance on the mq_freeze_depth counter.
    > Wouldn't it be better to move the call to 'nvme_start_freeze()' out of
    > the if() condition to avoid the imbalance?

    What about something like nmve_is_frozen() which would avoid the tracking
    of the queue state open coded as it is right?

    \
     
     \ /
      Last update: 2021-08-04 10:08    [W:5.626 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site