Messages in this thread Patch in this message | | | From | Daniel Wagner <> | Subject | [PATCH v4 7/8] nvme-tcp: Unfreeze queues on reconnect | Date | Mon, 2 Aug 2021 13:26:57 +0200 |
| |
During the queue teardown in nvme_tcp_teardown_io_queues() freeze is called unconditionally. When we reconnect we need to pair the freeze with an unfreeze to avoid hanging I/Os. For newly created connection this is not needed.
Fixes: 2875b0aecabe ("nvme-tcp: fix controller reset hang during traffic") Signed-off-by: Daniel Wagner <dwagner@suse.de> --- drivers/nvme/host/tcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 32268f24f62a..097f7dd10ed3 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -1819,9 +1819,11 @@ static int nvme_tcp_configure_io_queues(struct nvme_ctrl *ctrl, bool new) } blk_mq_update_nr_hw_queues(ctrl->tagset, ctrl->queue_count - 1); - nvme_unfreeze(ctrl); } + if (!new) + nvme_unfreeze(ctrl); + ret = nvme_tcp_start_io_queues(ctrl); if (ret) goto out_cleanup_connect_q; -- 2.29.2
| |