lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Freedreno] [PATCH 11/11] drm/msm/dsi: Pass DSC params to drm_panel
On 2021-07-14 23:52, Vinod Koul wrote:
> When DSC is enabled, we need to pass the DSC parameters to panel driver
> as well, so add a dsc parameter in panel and set it when DSC is enabled
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

based on the comments on prev patches in the series, this will need to
be reworked
too as there wont be any priv->dsc anymore.

Also, can you also post the panel changes? Would like to see how you
will use the
dsc param there.

> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 16 +++++++++++++++-
> include/drm/drm_panel.h | 7 +++++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c
> b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 4e8ab1b1df8b..ee21cda243a7 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -2193,6 +2193,7 @@ int msm_dsi_host_modeset_init(struct
> mipi_dsi_host *host,
> const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd;
> struct platform_device *pdev = msm_host->pdev;
> struct msm_drm_private *priv;
> + struct drm_panel *panel;
> int ret;
>
> msm_host->irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
> @@ -2212,8 +2213,21 @@ int msm_dsi_host_modeset_init(struct
> mipi_dsi_host *host,
> }
>
> msm_host->dev = dev;
> + panel = msm_dsi_host_get_panel(&msm_host->base);
> priv = dev->dev_private;
> - priv->dsc = msm_host->dsc;
> +
> + if (panel && panel->dsc) {
> + struct msm_display_dsc_config *dsc = priv->dsc;
> +
> + if (!dsc) {
> + dsc = kzalloc(sizeof(*dsc), GFP_KERNEL);
> + if (!dsc)
> + return -ENOMEM;
> + dsc->drm = panel->dsc;
> + priv->dsc = dsc;
> + msm_host->dsc = dsc;
> + }
> + }
>
> ret = cfg_hnd->ops->tx_buf_alloc(msm_host, SZ_4K);
> if (ret) {
> diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h
> index 33605c3f0eba..27a7808a29f2 100644
> --- a/include/drm/drm_panel.h
> +++ b/include/drm/drm_panel.h
> @@ -171,6 +171,13 @@ struct drm_panel {
> * Panel entry in registry.
> */
> struct list_head list;
> +
> + /**
> + * @dsc:
> + *
> + * Panel DSC pps payload to be sent
> + */
> + struct drm_dsc_config *dsc;
> };
>
> void drm_panel_init(struct drm_panel *panel, struct device *dev,

\
 
 \ /
  Last update: 2021-08-03 03:23    [W:0.198 / U:1.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site