Messages in this thread Patch in this message | | | From | Don Brace <> | Subject | [smartpqi updates PATCH 8/9] smartpqi: fix isr accessing null structure member | Date | Tue, 6 Jul 2021 13:16:17 -0500 |
| |
From: Mike McGowen <mike.mcgowen@microchip.com>
Correct driver's ISR accessing a data structure member that has not been fully initialized during driver init. - The pqi queue groups can be null when an interrupt fires.
Reviewed-by: Kevin Barnett <kevin.barnett@microchip.com> Reviewed-by: Scott Benesh <scott.benesh@microchip.com> Reviewed-by: Scott Teel <scott.teel@microchip.com> Signed-off-by: Mike McGowen <mike.mcgowen@microchip.com> Signed-off-by: Don Brace <don.brace@microchip.com> --- drivers/scsi/smartpqi/smartpqi_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 6f2263abaa8c..eeaf0568b5e3 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -7757,11 +7757,11 @@ static int pqi_ctrl_init(struct pqi_ctrl_info *ctrl_info) pqi_init_operational_queues(ctrl_info); - rc = pqi_request_irqs(ctrl_info); + rc = pqi_create_queues(ctrl_info); if (rc) return rc; - rc = pqi_create_queues(ctrl_info); + rc = pqi_request_irqs(ctrl_info); if (rc) return rc; -- 2.28.0.rc1.9.ge7ae437ac1
| |