Messages in this thread | | | From | "Valdis Klētnieks" <> | Subject | Re: [RFC PATCH 1/8] docs: Add block device LED trigger documentation | Date | Wed, 28 Jul 2021 23:09:15 -0400 |
| |
On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said:
> +Create a new block device LED trigger:: > + > + # echo foo > /sys/class/block/led_trigger_new > + > +The name must be unique among all LED triggers (not just block device LED > +triggers). > + > +Create two more:: > + > + # echo bar baz > /sys/class/block/led_trigger_new
> + # cat /sys/class/block/led_trigger_list > + baz: 0 > + bar: 0 > + foo: 0
This looks like an abuse of the "one entry one value" rule for sysfs. Perhaps this should be a directory /sys/class/block/defined_triggers/ and separate files under that for foo, bar, and baz? That would probably make reference counting a lot easier as well.... [unhandled content-type:application/pgp-signature] | |