lkml.org 
[lkml]   [2021]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC PATCH 1/8] docs: Add block device LED trigger documentation
Date
On Wed, 28 Jul 2021 20:53:37 -0500, Ian Pilcher said:

> +Create a new block device LED trigger::
> +
> + # echo foo > /sys/class/block/led_trigger_new
> +
> +The name must be unique among all LED triggers (not just block device LED
> +triggers).
> +
> +Create two more::
> +
> + # echo bar baz > /sys/class/block/led_trigger_new

> + # cat /sys/class/block/led_trigger_list
> + baz: 0
> + bar: 0
> + foo: 0

This looks like an abuse of the "one entry one value" rule for sysfs.
Perhaps this should be a directory /sys/class/block/defined_triggers/
and separate files under that for foo, bar, and baz? That would probably
make reference counting a lot easier as well....
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-07-29 05:10    [W:0.227 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site