Messages in this thread | | | Date | Thu, 29 Jul 2021 10:54:13 +0200 | From | Pavel Machek <> | Subject | Re: [RFC PATCH 0/8] Add configurable block device LED triggers |
| |
Hi!
> This patch series adds configurable (i.e. user-defined) block device LED > triggers. > > * Triggers can be created, listed, and deleted via sysfs block class > attributes (led_trigger_{new,list,del}). > > * Once created, block device LED triggers are associated with LEDs just > like any other LED trigger (via /sys/class/leds/${LED}/trigger). > > * Each block device gains a new device attribute (led_trigger) that can > be used to associate the device with a trigger or clear its > association.
That's not how this is normally done.
We normally have a trigger ("block device activity") which can then expose parameters ("I watch for read" and "I monitor sda1").
Is there a reason normal solution can not be used?
Best regards, Pavel -- http://www.livejournal.com/~pavelmachek [unhandled content-type:application/pgp-signature] | |