Messages in this thread | | | Subject | Re: [RFC PATCH 2/8] block: Add block device LED trigger list | From | Ian Pilcher <> | Date | Thu, 29 Jul 2021 10:55:23 -0500 |
| |
On 7/28/21 10:14 PM, Valdis Klētnieks wrote: > Is this bisect-clean (as in "will it build properly with that config option > set after each of the succeeding patches")? Usually, the config option > is added in the *last* patch, so that even if you have a bisect issue > it won't manifest because it's wrapped in a '#ifdef CONFIG_WHATEVER' > that can't possibly be compiled in because there's no way for Kconfig > to set that variable.
Yes it is. I tested compiling each patch with the CONFIG option both enabled and disabled. (You will get an unused function warning for blk_ledtrig_find() until patch #3 is applied.)
I'll switch to adding the option in the last patch of the series in the future.
Thanks!
-- ======================================================================== In Soviet Russia, Google searches you! ========================================================================
| |