lkml.org 
[lkml]   [2021]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/4] arm64: dts: rockchip: rk3328: Enable USB3 on some SBCs
Date
From: Chen-Yu Tsai <wens@csie.org>

Hi everyone,

Here are some patches that enable USB3 on RK3328 SBCs that I own. The
changes are quite straightforward, except for the NanoPi R2S, which
has a USB3 Ethernet chip attached. I am aware that there's already a
patch [1] for that. This is my spin on things using the USB device
binding, with comments on how the USB ports are arranged, that I had
done but couldn't find the time to send out.

The last patch also results in some warnings from checkpatch.pl:

WARNING: DT compatible string "usbbda,8153" appears un-documented --
check ./Documentation/devicetree/bindings/
#88: FILE: arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts:398:
+ compatible = "usbbda,8153";

WARNING: DT compatible string vendor "usbbda" appears un-documented --
check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
#88: FILE: arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts:398:
+ compatible = "usbbda,8153";

At least the first warning should be covered by the USB device binding

Documentation/devicetree/bindings/usb/usb-device.yaml

while we probably should add an exception to vendor-prefixes.yaml for
the second warning.

Please let me know what you think.


Regards
ChenYu

[1] https://lore.kernel.org/linux-rockchip/20210405093423.16149-1-cnsztl@gmail.com/


Cameron Nemo (1):
arm64: dts: rockchip: rk3328: Enable USB3 for Rock64

Chen-Yu Tsai (3):
arm64: dts: rockchip: rk3328: Enable USB3 for ROC-RK3328-CC
arm64: dts: rockchip: rk3328: Enable USB3 for Rock Pi E
arm64: dts: rockchip: rk3328: Enable USB3 Ethernet on NanoPi R2S

.../boot/dts/rockchip/rk3328-nanopi-r2s.dts | 32 +++++++++++++++++++
.../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 5 +++
.../boot/dts/rockchip/rk3328-rock-pi-e.dts | 5 +++
.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 5 +++
4 files changed, 47 insertions(+)

--
2.31.1

\
 
 \ /
  Last update: 2021-05-04 10:39    [W:0.054 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site