Messages in this thread | | | Date | Wed, 26 May 2021 09:31:05 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v6 2/4] printk: Straighten out log_flags into printk_info_flags |
| |
On Tue 2021-05-25 13:35:29, John Ogness wrote: > On 2021-05-25, Petr Mladek <pmladek@suse.com> wrote: > >> diff --git a/kernel/printk/printk_ringbuffer.h b/kernel/printk/printk_ringbuffer.h > >> index 73cc80e01cef..71918d47ca95 100644 > >> --- a/kernel/printk/printk_ringbuffer.h > >> +++ b/kernel/printk/printk_ringbuffer.h > >> @@ -50,6 +50,12 @@ struct prb_data_blk_lpos { > >> unsigned long next; > >> }; > >> > >> +/* Flags for a single printk record. */ > >> +enum printk_info_flags { > >> + LOG_NEWLINE = 2, /* text ended with a newline */ > >> + LOG_CONT = 8, /* text is a fragment of a continuation line */ > >> +}; > > > > Nit: Could you please move this after "enum desc_state" declaration? > > Is there a reason that this enum is moved into printk_ringbuffer.h? The > ringbuffer does not use this enum.
We want to use it in two source files: printk.c and index.c Alternative solution would be to move it to kernel/printk/internal.h.
Well, will internal.h still be needed after we remove printk_safe?
Anyway, I do not have strong opinion about it.
Best Regards, Petr
| |