Messages in this thread | | | Date | Tue, 25 May 2021 12:33:33 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v6 2/4] printk: Straighten out log_flags into printk_info_flags |
| |
On Tue 2021-05-18 13:00:38, Chris Down wrote: > In the past, `enum log_flags` was part of `struct log`, hence the name. > `struct log` has since been reworked and now this struct is stored > inside `struct printk_info`. However, the name was never updated, which > is somewhat confusing -- especially since these flags operate at the > record level rather than at the level of an abstract log. > > printk_info_flags also joins its other metadata struct friends in > printk_ringbuffer.h. > > Signed-off-by: Chris Down <chris@chrisdown.name> > Cc: Petr Mladek <pmladek@suse.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Just one nit below.
> diff --git a/kernel/printk/printk_ringbuffer.h b/kernel/printk/printk_ringbuffer.h > index 73cc80e01cef..71918d47ca95 100644 > --- a/kernel/printk/printk_ringbuffer.h > +++ b/kernel/printk/printk_ringbuffer.h > @@ -50,6 +50,12 @@ struct prb_data_blk_lpos { > unsigned long next; > }; > > +/* Flags for a single printk record. */ > +enum printk_info_flags { > + LOG_NEWLINE = 2, /* text ended with a newline */ > + LOG_CONT = 8, /* text is a fragment of a continuation line */ > +};
Nit: Could you please move this after "enum desc_state" declaration?
> /* > * A descriptor: the complete meta-data for a record. > * > -- > 2.31.1
Best Regards, Petr
| |