Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH v6 2/4] printk: Straighten out log_flags into printk_info_flags | Date | Tue, 25 May 2021 13:35:29 +0200 |
| |
On 2021-05-25, Petr Mladek <pmladek@suse.com> wrote: >> diff --git a/kernel/printk/printk_ringbuffer.h b/kernel/printk/printk_ringbuffer.h >> index 73cc80e01cef..71918d47ca95 100644 >> --- a/kernel/printk/printk_ringbuffer.h >> +++ b/kernel/printk/printk_ringbuffer.h >> @@ -50,6 +50,12 @@ struct prb_data_blk_lpos { >> unsigned long next; >> }; >> >> +/* Flags for a single printk record. */ >> +enum printk_info_flags { >> + LOG_NEWLINE = 2, /* text ended with a newline */ >> + LOG_CONT = 8, /* text is a fragment of a continuation line */ >> +}; > > Nit: Could you please move this after "enum desc_state" declaration?
Is there a reason that this enum is moved into printk_ringbuffer.h? The ringbuffer does not use this enum.
John Ogness
| |