Messages in this thread | | | Date | Fri, 30 Apr 2021 22:11:21 +0200 | From | Marek Behun <> | Subject | Re: [RFC PATCH 2/2] leds: trigger: implement block trigger |
| |
On Fri, 30 Apr 2021 15:32:11 -0300 Enzo Matsumiya <ematsumiya@suse.de> wrote:
> Activity is then represented in an accumulated manner (part_read_stat_accum()), > with a fixed blinking interval of 50ms.
part_stat_read_accum, not part_read_stat_accum
Why only accum? With the netdev trigger, you can choose whether rx, tx, or both are blinking the LED.
Also I think the trigger should be called "blockdev" instead of "block". This is consistent with "netdev", and avoids misinterpretation with the verb "to block".
Marek
| |