Messages in this thread |  | | Date | Sun, 2 May 2021 23:38:45 -0300 | From | Enzo Matsumiya <> | Subject | Re: [RFC PATCH 2/2] leds: trigger: implement block trigger |
| |
On 04/30, Randy Dunlap wrote: >On 4/30/21 11:32 AM, Enzo Matsumiya wrote: >> diff --git a/drivers/leds/trigger/Kconfig b/drivers/leds/trigger/Kconfig >> index b77a01bd27f4..bead31a19148 100644 >> --- a/drivers/leds/trigger/Kconfig >> +++ b/drivers/leds/trigger/Kconfig >> @@ -153,4 +153,14 @@ config LEDS_TRIGGER_TTY >> >> When build as a module this driver will be called ledtrig-tty. >> >> +config LEDS_TRIGGER_BLOCK >> + tristate "LED Block Device Trigger" >> + depends on BLOCK >> + default m > >Drop the "default m". We don't enable drivers (even to build modules) >unless they are necessary, e.g., for booting. > >> + help >> + This allows LEDs to be controlled by block device activity. >> + This trigger doesn't require the lower level drivers to have any >> + instrumentation. The activity is collected by polling the disk stats. >> + If unsure, say Y. >> + >> endif # LEDS_TRIGGERS > >thanks. >-- >~Randy
Thanks, will do in v2.
Cheers,
Enzo
|  |