Messages in this thread | | | From | Borislav Petkov <> | Subject | [PATCH v2 00/21] x86/insn: Add an insn_decode() API | Date | Wed, 24 Feb 2021 12:02:12 +0100 |
| |
From: Borislav Petkov <bp@suse.de>
Hi all,
finally had some time during the merge window to finish reworking this. Most if not all review feedback should be incorporated.
Thx.
Changelog: ==========
v1: ---
here's v1 with the requested change to return -ENODATA on short input to the decoder. The rest is as in the previous submission.
Only lightly tested.
Thx.
v0: ---
https://lkml.kernel.org/r/20201124101952.7909-1-bp@alien8.de
here's what I had in mind, finally split into proper patches. The final goal is for all users of the decoder to simply call insn_decode() and look at its retval. Simple.
As to amluto's question about detecting partial insns, see the diff below.
Running that gives:
insn buffer: 0x48 0xcf 0x48 0x83 0x90 0x90 0x90 0x90 0x90 0x90 0x90 0x90 0x90 0x90 0x90 supplied buf size: 15, ret 0 supplied buf size: 2, ret 0 supplied buf size: 3, ret 0 supplied buf size: 4, ret 0
and the return value is always success.
Which means that that buf_len that gets supplied to the decoder functions doesn't really work and I need to look into it.
That is, provided this is how we want to control what the instruction decoder decodes - by supplying the length of the buffer it should look at.
We could also say that probably there should be a way to say "decode only the first insn in the buffer and ignore the rest". That is all up to the use cases so I'm looking for suggestions here.
In any case, at least the case where I give it
0x48 0xcf 0x48 0x83
and say that buf size is 4, should return an error because the second insn is incomplete. So I need to go look at that now.
Borislav Petkov (21): x86/insn: Rename insn_decode() to insn_decode_from_regs() x86/insn: Add @buf_len param to insn_init() kernel-doc comment x86/insn: Add a __ignore_sync_check__ marker x86/insn: Add an insn_decode() API x86/insn-eval: Handle return values from the decoder x86/boot/compressed/sev-es: Convert to insn_decode() perf/x86/intel/ds: Check insn_get_length() retval perf/x86/intel/ds: Check return values of insn decoder functions x86/alternative: Use insn_decode() x86/mce: Convert to insn_decode() x86/kprobes: Convert to insn_decode() x86/sev-es: Split vc_decode_insn() x86/sev-es: Convert to insn_decode() x86/traps: Convert to insn_decode() x86/uprobes: Convert to insn_decode() x86/tools/insn_decoder_test: Convert to insn_decode() tools/objtool: Convert to insn_decode() x86/tools/insn_sanity: Convert to insn_decode() tools/perf: Convert to insn_decode() x86/insn: Remove kernel_insn_init() x86/insn: Make insn_complete() static
arch/x86/boot/compressed/sev-es.c | 11 +- arch/x86/events/intel/ds.c | 11 +- arch/x86/events/intel/lbr.c | 10 +- arch/x86/include/asm/inat.h | 2 +- arch/x86/include/asm/insn-eval.h | 4 +- arch/x86/include/asm/insn.h | 44 ++- arch/x86/kernel/alternative.c | 6 +- arch/x86/kernel/cpu/mce/severity.c | 12 +- arch/x86/kernel/kprobes/core.c | 17 +- arch/x86/kernel/kprobes/opt.c | 9 +- arch/x86/kernel/sev-es.c | 63 +++-- arch/x86/kernel/traps.c | 7 +- arch/x86/kernel/umip.c | 2 +- arch/x86/kernel/uprobes.c | 8 +- arch/x86/lib/inat.c | 2 +- arch/x86/lib/insn-eval.c | 40 +-- arch/x86/lib/insn.c | 255 ++++++++++++++---- arch/x86/tools/insn_decoder_test.c | 10 +- arch/x86/tools/insn_sanity.c | 8 +- tools/arch/x86/include/asm/inat.h | 2 +- tools/arch/x86/include/asm/insn.h | 44 ++- tools/arch/x86/lib/inat.c | 2 +- tools/arch/x86/lib/insn.c | 255 ++++++++++++++---- tools/include/linux/kconfig.h | 73 +++++ tools/objtool/arch/x86/decode.c | 9 +- tools/objtool/sync-check.sh | 17 +- tools/perf/arch/x86/tests/insn-x86.c | 9 +- tools/perf/arch/x86/util/archinsn.c | 9 +- tools/perf/check-headers.sh | 15 +- .../intel-pt-decoder/intel-pt-insn-decoder.c | 17 +- 30 files changed, 678 insertions(+), 295 deletions(-) create mode 100644 tools/include/linux/kconfig.h
-- 2.29.2
| |