lkml.org 
[lkml]   [2021]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 16/21] x86/tools/insn_decoder_test: Convert to insn_decode()
    Date
    From: Borislav Petkov <bp@suse.de>

    Simplify code, no functional changes.

    Signed-off-by: Borislav Petkov <bp@suse.de>
    ---
    arch/x86/tools/insn_decoder_test.c | 10 ++++++----
    1 file changed, 6 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/tools/insn_decoder_test.c b/arch/x86/tools/insn_decoder_test.c
    index 34eda63c124b..472540aeabc2 100644
    --- a/arch/x86/tools/insn_decoder_test.c
    +++ b/arch/x86/tools/insn_decoder_test.c
    @@ -120,7 +120,7 @@ int main(int argc, char **argv)

    while (fgets(line, BUFSIZE, stdin)) {
    char copy[BUFSIZE], *s, *tab1, *tab2;
    - int nb = 0;
    + int nb = 0, ret;
    unsigned int b;

    if (line[0] == '<') {
    @@ -148,10 +148,12 @@ int main(int argc, char **argv)
    } else
    break;
    }
    +
    /* Decode an instruction */
    - insn_init(&insn, insn_buff, sizeof(insn_buff), x86_64);
    - insn_get_length(&insn);
    - if (insn.length != nb) {
    + ret = insn_decode(&insn, insn_buff, sizeof(insn_buff),
    + x86_64 ? INSN_MODE_64 : INSN_MODE_32);
    +
    + if (ret < 0 || insn.length != nb) {
    warnings++;
    pr_warn("Found an x86 instruction decoder bug, "
    "please report this.\n", sym);
    --
    2.29.2
    \
     
     \ /
      Last update: 2021-02-24 12:12    [W:4.089 / U:1.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site