Messages in this thread Patch in this message | | | From | Randy Dunlap <> | Subject | [PATCH] btrfs: ref-verify: use 'inline void' keyword ordering | Date | Thu, 18 Feb 2021 22:54:17 -0800 |
| |
Fix build warnings of function signature when CONFIG_STACKTRACE is not enabled by reordering the 'inline' and 'void' keywords.
../fs/btrfs/ref-verify.c:221:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void inline __save_stack_trace(struct ref_action *ra) ../fs/btrfs/ref-verify.c:225:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void inline __print_stack_trace(struct btrfs_fs_info *fs_info,
Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Josef Bacik <jbacik@fb.com> Cc: David Sterba <dsterba@suse.com> Cc: Chris Mason <clm@fb.com> Cc: linux-btrfs@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> --- Found in mmotm; applies to mainline.
Apparently we are doing more '-W' checking than when this change was made in 2017.
fs/btrfs/ref-verify.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- mmotm-2021-0218-1829.orig/fs/btrfs/ref-verify.c +++ mmotm-2021-0218-1829/fs/btrfs/ref-verify.c @@ -218,11 +218,11 @@ static void __print_stack_trace(struct b stack_trace_print(ra->trace, ra->trace_len, 2); } #else -static void inline __save_stack_trace(struct ref_action *ra) +static inline void __save_stack_trace(struct ref_action *ra) { } -static void inline __print_stack_trace(struct btrfs_fs_info *fs_info, +static inline void __print_stack_trace(struct btrfs_fs_info *fs_info, struct ref_action *ra) { btrfs_err(fs_info, " ref-verify: no stacktrace support");
| |