Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 22 Feb 2021 12:47:06 +0100 | Subject | Re: [PATCH] btrfs: ref-verify: use 'inline void' keyword ordering |
| |
On Fri, Feb 19, 2021 at 7:57 AM Randy Dunlap <rdunlap@infradead.org> wrote: > Fix build warnings of function signature when CONFIG_STACKTRACE is not > enabled by reordering the 'inline' and 'void' keywords. > > ../fs/btrfs/ref-verify.c:221:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > static void inline __save_stack_trace(struct ref_action *ra) > ../fs/btrfs/ref-verify.c:225:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] > static void inline __print_stack_trace(struct btrfs_fs_info *fs_info, > > Fixes: fd708b81d972 ("Btrfs: add a extent ref verify tool") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Josef Bacik <jbacik@fb.com> > Cc: David Sterba <dsterba@suse.com> > Cc: Chris Mason <clm@fb.com> > Cc: linux-btrfs@vger.kernel.org > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > Found in mmotm; applies to mainline.
Thanks, fixes the warning in mainline for me. Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |