Messages in this thread Patch in this message | | | From | Yihao Han <> | Subject | [PATCH v2] samples/bpf: xdpsock: fix swap.cocci warning | Date | Thu, 9 Dec 2021 01:22:50 -0800 |
| |
Fix following swap.cocci warning: ./samples/bpf/xdpsock_user.c:528:22-23: WARNING opportunity for swap()
Signed-off-by: Yihao Han <hanyihao@vivo.com> --- Change log: v2: - Remove temp variable. --- samples/bpf/xsk_fwd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/samples/bpf/xsk_fwd.c b/samples/bpf/xsk_fwd.c index 1cd97c84c337..db15323728c0 100644 --- a/samples/bpf/xsk_fwd.c +++ b/samples/bpf/xsk_fwd.c @@ -651,11 +651,8 @@ static void swap_mac_addresses(void *data) struct ether_header *eth = (struct ether_header *)data; struct ether_addr *src_addr = (struct ether_addr *)ð->ether_shost; struct ether_addr *dst_addr = (struct ether_addr *)ð->ether_dhost; - struct ether_addr tmp; - tmp = *src_addr; - *src_addr = *dst_addr; - *dst_addr = tmp; + swap(*src_addr, *dst_addr); } static void * -- 2.17.1
| |