Messages in this thread | | | From | Toke Høiland-Jørgensen <> | Subject | Re: [PATCH v2] samples/bpf: xdpsock: fix swap.cocci warning | Date | Fri, 10 Dec 2021 15:26:30 +0100 |
| |
Yihao Han <hanyihao@vivo.com> writes:
> Fix following swap.cocci warning: > ./samples/bpf/xdpsock_user.c:528:22-23: > WARNING opportunity for swap() > > Signed-off-by: Yihao Han <hanyihao@vivo.com>
Erm, did this get applied without anyone actually trying to compile samples? I'm getting build errors as:
CC /home/build/linux/samples/bpf/xsk_fwd.o /home/build/linux/samples/bpf/xsk_fwd.c: In function ‘swap_mac_addresses’: /home/build/linux/samples/bpf/xsk_fwd.c:658:9: warning: implicit declaration of function ‘swap’; did you mean ‘swab’? [-Wimplicit-function-declaration] 658 | swap(*src_addr, *dst_addr); | ^~~~ | swab
/usr/bin/ld: /home/build/linux/samples/bpf/xsk_fwd.o: in function `thread_func': xsk_fwd.c:(.text+0x440): undefined reference to `swap' collect2: error: ld returned 1 exit status
Could we maybe get samples/bpf added to the BPF CI builds? :)
-Toke
| |