Messages in this thread | | | From | Martin Blumenstingl <> | Date | Thu, 30 Dec 2021 23:44:37 +0100 | Subject | Re: [PATCH V3 5/6] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit |
| |
On Thu, Dec 30, 2021 at 11:22 AM Yu Tu <yu.tu@amlogic.com> wrote: [...] > val = readl(port->membase + AML_UART_CONTROL); > - val &= ~AML_UART_RX_EN; > + val &= ~(AML_UART_RX_EN | AML_UART_TX_EN); > val &= ~(AML_UART_RX_INT_EN | AML_UART_TX_INT_EN); > writel(val, port->membase + AML_UART_CONTROL); This looks fine to me but I think it would be good to Cc the author of commit 855ddcab352c15 ("ARM: meson: serial: only disable tx irq on stop") The meson_uart driver which Carlo added eight years ago did clear AML_UART_TX_EN here, but it was changed with the commit I mentioned above.
Best regards, Martin
| |