lkml.org 
[lkml]   [2021]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V3 5/6] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit
From


On 2021/12/31 6:44, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
>
> On Thu, Dec 30, 2021 at 11:22 AM Yu Tu <yu.tu@amlogic.com> wrote:
> [...]
>> val = readl(port->membase + AML_UART_CONTROL);
>> - val &= ~AML_UART_RX_EN;
>> + val &= ~(AML_UART_RX_EN | AML_UART_TX_EN);
>> val &= ~(AML_UART_RX_INT_EN | AML_UART_TX_INT_EN);
>> writel(val, port->membase + AML_UART_CONTROL);
> This looks fine to me but I think it would be good to Cc the author of
> commit 855ddcab352c15 ("ARM: meson: serial: only disable tx irq on
> stop")
> The meson_uart driver which Carlo added eight years ago did clear
> AML_UART_TX_EN here, but it was changed with the commit I mentioned
> above.
>
I'm going to delete this change this time. Because there is no bug at
present, if this is a bug encountered later, i will prepare to submit
this change.
>
> Best regards,
> Martin
>

\
 
 \ /
  Last update: 2021-12-31 11:43    [W:0.061 / U:4.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site