Messages in this thread | | | Date | Fri, 31 Dec 2021 18:37:42 +0800 | Subject | Re: [PATCH V3 6/6] tty: serial: meson: Change request_irq to devm_request_irq and move devm_request_irq to meson_uart_probe() | From | Yu Tu <> |
| |
On 2021/12/31 6:41, Martin Blumenstingl wrote: > [ EXTERNAL EMAIL ] > > On Thu, Dec 30, 2021 at 11:22 AM Yu Tu <yu.tu@amlogic.com> wrote: >> >> Because an interrupt error occurs when the user opens /dev/ttyAML* but >> don't close it, and then opens the same port again. This problem is >> encountered in actual projects. > I would like to hear from the serial driver maintainers whether the > described problem is a userspace or driver bug. > > If it's a driver bug then this should be sent as a separate patch > (unrelated to this series) with a fixes tag. > > [...] >> + ret = devm_request_irq(&pdev->dev, port->irq, meson_uart_interrupt, >> + 0, dev_name(&pdev->dev), port); > You can replace dev_name(&pdev->dev) with NULL to achieve the same > result with less code. > dev_name(dev) is the default value, see [0] > I think you are right, I will remove this patch. I learned a lot. > > Best regards, > Martin > > > [0] https://elixir.bootlin.com/linux/v5.15/source/kernel/irq/devres.c#L64 >
| |