lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 7/9] watchdog: max77620: add support for the max77714 variant
From
Date
On 12/11/21 12:34 PM, Luca Ceresoli wrote:
> The MAX77714 is a MFD chip whose watchdog has the same programming
> procedures as the MAX77620 watchdog, but most register offsets and bit
> masks are different, as well as some features.
>
> Support the MAX77714 watchdog by adding a variant description table holding
> the differences.
>
> All the features implemented by this driver are available on the MAX77714
> except for the lack of a WDTOFFC bit. Instead of using a "HAS_*" flag we
> handle this by holding in the cnfg_glbl2_cfg_bits struct field the bits
> (i.e. the features) to enable in the CNFG_GLBL2 register. These bits differ
> among the two models. This implementation allows to avoid any conditional
> code, keeping the execution flow unchanged.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>


Reviewed-by: Guenter Roeck <linux@roeck-us.net>


\
 
 \ /
  Last update: 2021-12-21 16:06    [W:0.130 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site