lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 5/9] mfd: max77714: Add driver for Maxim MAX77714 PMIC
From
Date
Hi Lee,

On 21/12/21 10:29, Lee Jones wrote:
> On Sat, 11 Dec 2021, Luca Ceresoli wrote:
>
>> Add a simple driver for the Maxim MAX77714 PMIC, supporting RTC and
>> watchdog only.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>
>> ---
>>
>> Changes in v5: none
>>
>> Changes in v4: none
>>
>> Changes in v3:
>> - Suggested by Lee Jones:
>> - move struct mfd_cell to top of file
>> - remove struct max77714 and its kmalloc, not used after probe
>> - reword error messages
>> - add "/* pF */" onto the end of the load_cap line
>>
>> Changes in v2:
>> - fix "watchdog" word in heading comment (Guenter Roeck)
>> - move struct max77714 to .c file (Krzysztof Kozlowski)
>> - change include guard format (Krzysztof Kozlowski)
>> - allow building as a module (Krzysztof Kozlowski)
>> - remove of_match_ptr usage (Krzysztof Kozlowski / lkp)
>> (Reported-by: kernel test robot <lkp@intel.com>)
>> ---
>> MAINTAINERS | 2 +
>> drivers/mfd/Kconfig | 14 ++++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/max77714.c | 152 +++++++++++++++++++++++++++++++++++
>> include/linux/mfd/max77714.h | 60 ++++++++++++++
>> 5 files changed, 229 insertions(+)
>> create mode 100644 drivers/mfd/max77714.c
>> create mode 100644 include/linux/mfd/max77714.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index a08f5167dfe0..ef3ffba828af 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11586,6 +11586,8 @@ MAXIM MAX77714 PMIC MFD DRIVER
>> M: Luca Ceresoli <luca@lucaceresoli.net>
>> S: Maintained
>> F: Documentation/devicetree/bindings/mfd/maxim,max77714.yaml
>> +F: drivers/mfd/max77714.c
>> +F: include/linux/mfd/max77714.h
>>
>> MAXIM MAX77802 PMIC REGULATOR DEVICE DRIVER
>> M: Javier Martinez Canillas <javier@dowhile0.org>
>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
>> index 3fb480818599..1b9d772bdae6 100644
>> --- a/drivers/mfd/Kconfig
>> +++ b/drivers/mfd/Kconfig
>> @@ -855,6 +855,20 @@ config MFD_MAX77693
>> additional drivers must be enabled in order to use the functionality
>> of the device.
>>
>> +config MFD_MAX77714
>> + tristate "Maxim Semiconductor MAX77714 PMIC Support"
>> + depends on I2C
>> + depends on OF || COMPILE_TEST
>> + select MFD_CORE
>> + select REGMAP_I2C
>> + help
>> + Say yes here to add support for Maxim Semiconductor MAX77714.
>> + This is a Power Management IC with 4 buck regulators, 9
>> + low-dropout regulators, 8 GPIOs, RTC, watchdog etc. This driver
>> + provides common support for accessing the device; additional
>> + drivers must be enabled in order to use each functionality of the
>> + device.
>> +
>> config MFD_MAX77843
>> bool "Maxim Semiconductor MAX77843 PMIC Support"
>> depends on I2C=y
>> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
>> index 0b1b629aef3e..03115cf1336b 100644
>> --- a/drivers/mfd/Makefile
>> +++ b/drivers/mfd/Makefile
>> @@ -162,6 +162,7 @@ obj-$(CONFIG_MFD_MAX77620) += max77620.o
>> obj-$(CONFIG_MFD_MAX77650) += max77650.o
>> obj-$(CONFIG_MFD_MAX77686) += max77686.o
>> obj-$(CONFIG_MFD_MAX77693) += max77693.o
>> +obj-$(CONFIG_MFD_MAX77714) += max77714.o
>> obj-$(CONFIG_MFD_MAX77843) += max77843.o
>> obj-$(CONFIG_MFD_MAX8907) += max8907.o
>> max8925-objs := max8925-core.o max8925-i2c.o
>> diff --git a/drivers/mfd/max77714.c b/drivers/mfd/max77714.c
>> new file mode 100644
>> index 000000000000..08dfb69bc6e8
>> --- /dev/null
>> +++ b/drivers/mfd/max77714.c
>> @@ -0,0 +1,152 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Maxim MAX77714 MFD Driver
>
> I'm only mentioning this because you are still missing some reviews.
>
> But I'd prefer for drivers not to describe themselves as MFD Drivers.
>
> The term Parent or Core driver is usually better.
>
> If you have to respin the set, please fix it.

OK. However No plan for a new iteration, but the wdog patches still need
a review so it's possible. I don't expect changes for the other patches,
they are acked and unchanged since a couple iterations.

> If not, please sent a subsequent fix-up.

Sure. Maybe I'll find some good will and reword all drivers which
currently self-describe as "MFD drivers".

> Acked-by: Lee Jones <lee.jones@linaro.org>

Thanks.
--
Luca

\
 
 \ /
  Last update: 2021-12-21 10:38    [W:0.136 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site