lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] mfd: rk808: add reboot support to rk808.c
From
Am 21. Dezember 2021 09:48:43 MEZ schrieb Lee Jones <lee.jones@linaro.org>:
>On Mon, 20 Dec 2021, Frank Wunderlich wrote:
>
>> Hi
>>
>> > Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
>> > Von: "Peter Geis" <pgwipeout@gmail.com>
>> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client
>*client)
>> > if (pm_power_off == rk808_pm_power_off)
>> > pm_power_off = NULL;
>> >
>> > + if (of_property_read_bool(np,
>"rockchip,system-power-controller"))
>> > + unregister_restart_handler(&rk808_restart_handler);
>> > +
>> > return 0;
>> > }
>>
>> this change misses a declaration
>>
>> struct device_node *np = client->dev.of_node;
>
>How did this compile when you tested it?

Here i have squashed the change in:

https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb940256de77807ed620f

With the change i can compile it...

But in v4 (patch is tagged as v3 too) the of_property_read_bool was dropped completely.
regards Frank

\
 
 \ /
  Last update: 2021-12-21 10:11    [W:0.068 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site