Messages in this thread | | | Subject | Re: Aw: [PATCH v3] mfd: rk808: add reboot support to rk808.c | From | Dmitry Osipenko <> | Date | Mon, 20 Dec 2021 19:36:53 +0300 |
| |
20.12.2021 19:33, Frank Wunderlich пишет: > Hi > >> Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr >> Von: "Peter Geis" <pgwipeout@gmail.com> >> @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client) >> if (pm_power_off == rk808_pm_power_off) >> pm_power_off = NULL; >> >> + if (of_property_read_bool(np, "rockchip,system-power-controller")) >> + unregister_restart_handler(&rk808_restart_handler); >> + >> return 0; >> } > > this change misses a declaration > > struct device_node *np = client->dev.of_node;
Good catch, technically the whole of_property_read_bool() could be dropped from rk808_remove() since unregister_restart_handler() survives if handler wasn't registered.
| |