lkml.org 
[lkml]   [2021]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: Aw: [PATCH v3] mfd: rk808: add reboot support to rk808.c
    From
    Date
    20.12.2021 19:33, Frank Wunderlich пишет:
    > Hi
    >
    >> Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
    >> Von: "Peter Geis" <pgwipeout@gmail.com>
    >> @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
    >> if (pm_power_off == rk808_pm_power_off)
    >> pm_power_off = NULL;
    >>
    >> + if (of_property_read_bool(np, "rockchip,system-power-controller"))
    >> + unregister_restart_handler(&rk808_restart_handler);
    >> +
    >> return 0;
    >> }
    >
    > this change misses a declaration
    >
    > struct device_node *np = client->dev.of_node;

    Good catch, technically the whole of_property_read_bool() could be
    dropped from rk808_remove() since unregister_restart_handler() survives
    if handler wasn't registered.

    \
     
     \ /
      Last update: 2021-12-20 17:37    [W:2.614 / U:0.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site