Messages in this thread | | | Date | Wed, 22 Dec 2021 11:09:56 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c |
| |
On Tue, 21 Dec 2021, Frank Wunderlich wrote:
> Am 21. Dezember 2021 09:48:43 MEZ schrieb Lee Jones <lee.jones@linaro.org>: > >On Mon, 20 Dec 2021, Frank Wunderlich wrote: > > > >> Hi > >> > >> > Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr > >> > Von: "Peter Geis" <pgwipeout@gmail.com> > >> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client > >*client) > >> > if (pm_power_off == rk808_pm_power_off) > >> > pm_power_off = NULL; > >> > > >> > + if (of_property_read_bool(np, > >"rockchip,system-power-controller")) > >> > + unregister_restart_handler(&rk808_restart_handler); > >> > + > >> > return 0; > >> > } > >> > >> this change misses a declaration > >> > >> struct device_node *np = client->dev.of_node; > > > >How did this compile when you tested it? > > Here i have squashed the change in: > > https://github.com/frank-w/BPI-R2-4.14/commit/06430ffcb6d58d33014fb940256de77807ed620f > > With the change i can compile it...
Not sure I understand.
Please make sure all patches you send for inclusion into the Linux kernel are fully tested. They should also be bisectable i.e. not depend on patches applied *on top*.
> But in v4 (patch is tagged as v3 too) the of_property_read_bool was dropped completely. > regards Frank
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |