Messages in this thread | | | Date | Mon, 1 Nov 2021 09:31:57 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v9 4/5] usb: dwc3: qcom: Change the IRQ flag for DP/DM hs phy irq |
| |
On Mon 01 Nov 00:53 PDT 2021, Sandeep Maheswaram wrote:
> Change the IRQ flags for DP/DM hs phy irq to avoid interrupt > triggering during system suspend. >
Why does replacing HIGH with RISING change this behavior, or do you get a RISING interrupt just before hitting suspend which you ignore?
I think it would be nice to have the commit message for this (or per below request the DTS change) include some details about what's really happening on the irq line.
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com> > --- > drivers/usb/dwc3/dwc3-qcom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 54461f1..356f4f8 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -473,7 +473,7 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) > irq_set_status_flags(irq, IRQ_NOAUTOEN); > ret = devm_request_threaded_irq(qcom->dev, irq, NULL, > qcom_dwc3_resume_irq, > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
IRQF_TRIGGER_* should be omitted from the driver and supplied by the DT.
The dtbs out there should all have IRQ_TYPE_LEVEL_HIGH at this time, so simply dropping that from this list and updating the dts would be the right thing to do.
Regards, Bjorn
> "qcom_dwc3 DP_HS", qcom); > if (ret) { > dev_err(qcom->dev, "dp_hs_phy_irq failed: %d\n", ret); > @@ -488,7 +488,7 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) > irq_set_status_flags(irq, IRQ_NOAUTOEN); > ret = devm_request_threaded_irq(qcom->dev, irq, NULL, > qcom_dwc3_resume_irq, > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > "qcom_dwc3 DM_HS", qcom); > if (ret) { > dev_err(qcom->dev, "dm_hs_phy_irq failed: %d\n", ret); > -- > 2.7.4 >
| |