lkml.org 
[lkml]   [2021]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] cpu/hotplug: Fix CPU down rollback
On Mon, Jan 11, 2021 at 05:10:47PM +0000, vincent.donnefort@arm.com wrote:
> From: Vincent Donnefort <vincent.donnefort@arm.com>
>
> After the AP brought itself down to CPUHP_TEARDOWN_CPU, the BP will finish
> the job. The steps left are as followed:
>
> +--------------------+
> | CPUHP_TEARDOWN_CPU | -> If fails state is CPUHP_TEARDOWN_CPU
> +--------------------+
> | ATOMIC STATES | -> Cannot Fail
> +--------------------+
> | CPUHP_BRINGUP_CPU | -> Cannot fail
> +--------------------+
> | ... |
> | ... | -> Can fail and rollback

These are the PREPARE/DEAD states, right? It would be _really_ daft for
a DEAD notifier to fail. But yeah, I suppose that if it does, it will
indeed end up in CPUHP_AP_ONLINE_IDLE.

Do we want to WARN when a DEAD notifier fails?


\
 
 \ /
  Last update: 2021-01-21 16:02    [W:0.122 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site