Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Wed, 20 Jan 2021 18:45:16 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() |
| |
On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote: > @@ -475,6 +478,11 @@ cpuhp_set_state(struct cpuhp_cpu_state *st, enum cpuhp_state target) > static inline void > cpuhp_reset_state(struct cpuhp_cpu_state *st, enum cpuhp_state prev_state) > { > + st->target = prev_state; > + > + if (st->rollback) > + return;
I'm thinking that if we call rollback while already rollback we're hosed something fierce, no?
That like going up, failing, going back down again, also failing, giving up in a fiery death.
| ![\](/images/icornerr.gif) |