Messages in this thread | | | Date | Wed, 20 Jan 2021 18:49:00 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range() |
| |
On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote: > + if (can_rollback_cpu(st)) > + WARN_ON(cpuhp_invoke_callback_range(false, cpu, st, > + prev_state));
> + if (ret) > /* > * DYING must not fail! > */ > WARN_ON_ONCE(ret); > - }
> + if (ret) { > + > + cpuhp_reset_state(st, prev_state); > + > + if (st->state < prev_state) > + WARN_ON(cpuhp_invoke_callback_range(true, cpu, st, > + prev_state)); > }
> + if (ret) > /* > * STARTING must not fail! > */ > WARN_ON_ONCE(ret); > - }
Stuff like that is CodingStyle fail.
| |