lkml.org 
[lkml]   [2021]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range()
On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@arm.com wrote:
> + if (can_rollback_cpu(st))
> + WARN_ON(cpuhp_invoke_callback_range(false, cpu, st,
> + prev_state));

> + if (ret)
> /*
> * DYING must not fail!
> */
> WARN_ON_ONCE(ret);
> - }

> + if (ret) {
> +
> + cpuhp_reset_state(st, prev_state);
> +
> + if (st->state < prev_state)
> + WARN_ON(cpuhp_invoke_callback_range(true, cpu, st,
> + prev_state));
> }

> + if (ret)
> /*
> * STARTING must not fail!
> */
> WARN_ON_ONCE(ret);
> - }

Stuff like that is CodingStyle fail.

\
 
 \ /
  Last update: 2021-01-20 18:54    [W:0.144 / U:1.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site